Upgrade babel deps #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for contributing! I don't really want to upgrade to babel 7 before it comes out of beta. Are you having any issue that this PR fixes? |
Author
|
Agree with you!
I use Babel 7 in my project, and adding hex-to-rgba broke the build -
missing babel-preset-2015 - as it is replaced by @babel/preset-env.
Maybe it could be fixed by using peerDependancies?
In the meantime, it could be useful to release the Babel 7 upgrade under a
branch?
…On Wed., 21 Mar. 2018, 03:20 Just Thomas Hiorth Misund, < ***@***.***> wrote:
Thanks for contributing!
I don't really want to upgrade to babel 7 before it comes out of beta. Are
you having any issue that this PR fixes?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF3JFHXSos03wJwiCeQ0JrE4vMb7uMt3ks5tgSxLgaJpZM4SxMaz>
.
|
Owner
|
I'm going to wait for the release. If you want to roll your own in the mean time, something like this in your package.json would do the trick:
|
Author
|
Yep, no worries :) Already am using it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For modern builds