这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Apr 23, 2020. It is now read-only.

Upgrade pdfjs dist #1

Merged
merged 5 commits into from
Apr 13, 2020
Merged

Upgrade pdfjs dist #1

merged 5 commits into from
Apr 13, 2020

Conversation

kylemellander
Copy link
Collaborator

No description provided.

This updates to the latest version of pdfjs-dist.  The previous versions 
had a bug that caused cross site loading issues for some webpack builds.
With the newer version of pdfjs-dist, using the default EventBus has 
been deprectated. This sends in our own eventBus to manage the event 
messages.
The ES6 version requires support of ReadableStream causing issues.  
Rather than using a polyfill or mocking this, we should just assume that 
it has been compiled to a working syntax, which for the tests is ES5.
The updated pdfjs-dist library added an unscore to the location of the 
pageIndex.  This happens in real time, but since we are mocking it in 
the tests, we need to make sure to mock it correctly.
This is done to match the need to manually set the eventBus on a 
LinkService
@kylemellander kylemellander merged commit f368567 into master Apr 13, 2020
@kylemellander kylemellander deleted the upgrade-pdfjs-dist branch April 13, 2020 20:57
@kylemellander kylemellander restored the upgrade-pdfjs-dist branch April 13, 2020 20:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant