refactor(js): clean up modal_handler.js #3745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fguillot
reviewed
Sep 8, 2025
fguillot
reviewed
Sep 10, 2025
Since there is a single modal in miniflux, namely the keyboard help, there is no need to have a full-fledged focus stealer where an ad-hoc one would be enough. This simplifies the code and makes it way more understandable. We might want to move to the <dialog> tag at some point in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is a single modal in miniflux, namely the keyboard help, there is no need to have a full-fledged focus stealer where an ad-hoc one would be enough. This simplifies the code and makes it way more understandable.
We might want to move to the tag at some point in the future.