refactor(reponser): minor simplifications #3724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jvoisin
commented
Aug 20, 2025
- b.body can never be of type error, so let's remove it from the switch-case construct.
- there is no need to use defer when the only return statement is two lines after.
- b.body can never be of type error, so let's remove it from the switch-case construct. - there is no need to use defer when the only return statement is two lines after.
dsh2dsh
added a commit
to dsh2dsh/miniflux
that referenced
this pull request
Aug 21, 2025
Revert non actual miniflux#3722 Revert useless shit miniflux#3645 miniflux#3701 miniflux#3704 miniflux#3724 miniflux#3706 miniflux#3720 Partly adopt miniflux#3706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.