这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@AlfieJones
Copy link

@AlfieJones AlfieJones commented Jan 2, 2023

🎁 Pull Request

This pr exports 'If' properly and improves it's docs.

After this pr, you can now use

import {A} from 'ts-toolbelt'
type test = A.If<true, string>

  • Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tests folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Fixes

Why have you made changes?

What changes have you made?

  • changed this to achieve this
  • changed that to achieve this
  • ...

What tests have you updated?

  • tested this in tests/...
  • tested that in tests/...
  • ...

Is there any breaking changes?

  • Yes, I changed the public API & documented it
  • Yes, I changed existing tests
  • No, I added to the public API & documented it
  • No, I added to the existing tests
  • I don't know

Anything else worth mentioning?

@AlfieJones AlfieJones requested a review from millsp as a code owner January 2, 2023 21:16
@sweethuman
Copy link

@AlfieJones Want to publish a fork of it with the improvements? Maybe we can merge all the other improvements from other pull requests that haven't yet been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants