这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@karlhorky
Copy link

@karlhorky karlhorky commented Sep 24, 2022

🎁 Pull Request

  • Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tests folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Fixes

Adds a test case in the Function/Exact tests for excess property checking

Why have you made changes?

It was unclear whether Function/Exact supported excess property checking

What changes have you made?

  • added a test case

What tests have you updated?

  • added a test case in tests/Function

Is there any breaking changes?

  • Yes, I changed the public API & documented it
  • Yes, I changed existing tests
  • No, I added to the public API & documented it
  • No, I added to the existing tests
  • I don't know

Anything else worth mentioning?

Ref: #319 (comment)

@karlhorky karlhorky requested a review from millsp as a code owner September 24, 2022 15:03
@karlhorky karlhorky mentioned this pull request Sep 24, 2022
@karlhorky
Copy link
Author

@millsp would it be possible to get a review on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant