这是indexloc提供的服务，不要输入任何密码
Skip to content

fix #242 Infering an F.Curry type as it's "full" signature results in… #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix #242 Infering an F.Curry type as it's "full" signature results in… #243

wants to merge 2 commits into from

Conversation

@regevbr
Copy link
Contributor

@regevbr regevbr commented Jun 1, 2021

… unexpected behavior

🎁 Pull Request

  • [x ] Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tests folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Fixes

#242

Why have you made changes?

To support the ramada type defenitions

What changes have you made?

Added to F.Curry an overload of the complete signature of the curried function

What tests have you updated?

  • tested this in tests/Funcction.ts

Is there any breaking changes?

  • Yes, I changed the public API & documented it
  • Yes, I changed existing tests
  • No, I added to the public API & documented it
  • No, I added to the existing tests
  • I don't know

@regevbr regevbr requested a review from millsp as a code owner June 1, 2021 20:52
@regevbr
Copy link
Contributor Author

regevbr commented Jun 1, 2021 •
edited
Loading

@millsp seems that the failing tests are related to the newest version of typescript that was released 6 days ago (4.3.2) and not my changes. I'm trying to figure out what went wrong there but I'm still not sure

@regevbr
Copy link
Contributor Author

regevbr commented Jun 1, 2021

@millsp seems that the failing tests are related to the newest version of typescript that was released 6 days ago (4.3.2) and not my changes. I'm trying to figure out what went wrong there but I'm still not sure

Fixed it by adding another infer statement... Not sure why this issue happened though... nothing in the official release post.
@millsp can you please CR?

@regevbr
Copy link
Contributor Author

regevbr commented Jun 16, 2021

@millsp can you please CR?

1 similar comment
@regevbr
Copy link
Contributor Author

regevbr commented Jul 5, 2021

@millsp can you please CR?

@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 6, 2021
@stale stale bot closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@millsp millsp Awaiting requested review from millsp millsp is a code owner

Assignees

No one assigned

Labels

wontfix This will not be worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@regevbr