这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ssalbdivad
Copy link
Contributor

@ssalbdivad ssalbdivad commented Mar 4, 2021

🎁 Pull Request

  • Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tst folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Why have you made changes?

Users may want to leverage AutoPath for strings delimited by something other than "."

What changes have you made?

  • Added an additional "Delimiter" parameter to the AutoPath generic (defaults to ".")

What tests have you updated?

  • tested the Delimiter parameter in "tests/Function.ts"

Is there any breaking changes?

  • Yes, I changed the public API & documented it
  • Yes, I changed existing tests
  • No, I added to the public API & documented it
  • No, I added to the existing tests
  • I don't know

Anything else worth mentioning?

@ssalbdivad ssalbdivad requested a review from millsp as a code owner March 4, 2021 02:36
@ssalbdivad ssalbdivad changed the title Pr/autopath delimiter feat(paths): parameter for AutoPath delimiter Mar 4, 2021
@millsp millsp merged commit ed07ce9 into millsp:master Mar 10, 2021
@millsp
Copy link
Owner

millsp commented Mar 10, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants