Add Object/Members type to extract the list of member types of any object #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @Methrat0n, thanks for the proposition :) I will not merge this, but thanks for your nice intentions. I appreciate. We can re-write this like this: type equivalent = U.TupleOf<U.UnionOf<YOUR OBJECT>> |
Author
|
I respect your choice, but I want to point out that your solution is not equivalent: you lose the types that are present multiple times. My second example with 2 number would not give the same result as yours. |
Owner
|
Does this work four you? type Members<O extends object> =
U.ListOf<keyof O> extends infer LK
? {[K in keyof LK]: O.At<O, LK[K] & keyof O>}
: never
type test0 = Members<{a: 1, b: 2, c: {a: 1}}> |
Author
|
Yes, it does and thank's for the better implementation. That way of iterating over an array is really neet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎁 Pull Request
tstfolder)npm testFixes
There is no issue with this as the contributing section does not ask to create one first.
Why have you made changes?
I used ts-toolbet to create this type and use it in my library ts-match.
I think it can be of use to others and want to give back to this project which helps a lot in my work.
What changes have you made?
What tests have you updated?
Is there any breaking changes?
Anything else worth mentioning?
I commented one test which was failing and intends to create an issue about it.
I will gladly uncomment it if you prefer.