这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@mesqueeb
Copy link
Contributor

@mesqueeb mesqueeb commented Sep 4, 2020

🎁 Pull Request

  • Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tst folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Fixes

just a typo

What changes have you made?

fix the typo

What tests have you updated?

none

Is there any breaking changes?

no

@mesqueeb mesqueeb requested a review from millsp as a code owner September 4, 2020 23:45
@mesqueeb
Copy link
Contributor Author

mesqueeb commented Sep 4, 2020

@millsp hey, I didn't think following the complex contribution guide was necessary to just fix a typo in the docs/JSDocs, but I'm not sure. I just thought I'd open the PR and see what will happen. :D feel free to close if you don't like it because I didn't follow all the contribution guide lines!!

@millsp millsp added the docs Related to the docs label Sep 5, 2020
@millsp
Copy link
Owner

millsp commented Sep 5, 2020

Thank you so much, will merge soon

@millsp
Copy link
Owner

millsp commented Oct 6, 2020

I will merge this in the upcoming version 9. Thanks!

@stale
Copy link

stale bot commented Dec 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 6, 2020
@millsp millsp removed the wontfix This will not be worked on label Dec 6, 2020
@millsp
Copy link
Owner

millsp commented Jan 29, 2021

Merged! Thank you :)

@millsp millsp closed this Jan 29, 2021
@mesqueeb
Copy link
Contributor Author

@millsp really?? Says unmerged to me :P

@millsp
Copy link
Owner

millsp commented Jan 29, 2021

It's on my local next branch. Preparing for ts-toolbelt 9! Lots of cleaning, simplifying, optimizing, removing, & string utilities!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Related to the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants