这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(object): added Partial alias for OptionalPart #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 11, 2020
Merged

feat(object): added Partial alias for OptionalPart #123

merged 9 commits into from
Jul 11, 2020

Conversation

@mesqueeb
Copy link
Contributor

@mesqueeb mesqueeb commented Jul 6, 2020 •
edited
Loading

🎁 Pull Request

  • Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tst folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Fixes

What changes have you made?

  • added Partial type

What tests have you updated?

  • added Partial test in tst/object

Is there any breaking changes?

  • Yes, I changed the public API & documented it
  • Yes, I changed existing tests
  • No, I added to the public API & documented it
  • No, I added to the existing tests
  • I don't know

Anything else worth mentioning?

mesqueeb
mesqueeb commented Jul 6, 2020
View reviewed changes
mesqueeb
mesqueeb commented Jul 6, 2020
View reviewed changes
mesqueeb
mesqueeb commented Jul 6, 2020
View reviewed changes
mesqueeb
mesqueeb commented Jul 6, 2020
View reviewed changes
package.json Outdated
{
"name": "ts-toolbelt",
"version": "6.9.9",
"version": "6.10.0",
Copy link
Contributor Author

@mesqueeb mesqueeb Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pirix-gh this was auto incremented, I didn't touch anything!

@mesqueeb mesqueeb marked this pull request as ready for review July 6, 2020 00:32
@mesqueeb mesqueeb requested a review from millsp as a code owner July 6, 2020 00:32
millsp
millsp reviewed Jul 6, 2020
View reviewed changes
millsp
millsp reviewed Jul 6, 2020
View reviewed changes
millsp
millsp requested changes Jul 6, 2020
View reviewed changes
Copy link
Owner

@millsp millsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, please read the comments for the change requests. And there is one more thing: we need to keep parity with utilities in List, so the latter should also benefit from Partial.

Before you continue, don't forget to pull the few changes I made.

@mesqueeb
Copy link
Contributor Author

mesqueeb commented Jul 6, 2020

Cool! I'll do it tomorrow :)

@millsp
Copy link
Owner

millsp commented Jul 10, 2020

@mesqueeb ?

@mesqueeb
Copy link
Contributor Author

mesqueeb commented Jul 10, 2020

@pirix-gh sorry i suddenly got busy with some deadlines at work ><
I’ll hope to make some time this weekend!!

@mesqueeb
Copy link
Contributor Author

mesqueeb commented Jul 10, 2020

@pirix-gh I have added 2 extra commit implementing your requests.
Is there anything else I need to do ?

@mesqueeb mesqueeb requested a review from millsp July 10, 2020 23:34
@millsp millsp merged commit 657cca6 into millsp:master Jul 11, 2020
@millsp
Copy link
Owner

millsp commented Jul 11, 2020

That's it, thank you 🎉. I would be more than happy if you could help with the docs, even just a list of things that are unclear (no explanations needed), then I can work through it and ask you what was unclear if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@millsp millsp millsp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mesqueeb @millsp