这是indexloc提供的服务，不要输入任何密码
Skip to content

Pr/partial deep #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Pr/partial deep #122

wants to merge 8 commits into from

Conversation

mesqueeb
Copy link
Contributor

@mesqueeb mesqueeb commented Jul 3, 2020 •
edited
Loading

🎁 Pull Request

  • Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tst folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Fixes

#109

Why have you made changes?

What changes have you made?

  • changed this to achieve this
  • changed that to achieve this
  • ...

What tests have you updated?

  • tested this in tst/...
  • tested that in tst/...
  • ...

Is there any breaking changes?

  • Yes, I changed the public API & documented it
  • Yes, I changed existing tests
  • No, I added to the public API & documented it
  • No, I added to the existing tests
  • I don't know

Anything else worth mentioning?

@mesqueeb mesqueeb requested a review from millsp as a code owner July 3, 2020 22:28
@mesqueeb
Copy link
Contributor Author

mesqueeb commented Jul 3, 2020

@pirix-gh As per your request, here's the PR! Let me know if I need to add extra tests or not!!

millsp
millsp requested changes Jul 4, 2020
View reviewed changes
Copy link
Owner

@millsp millsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I cannot pull this, sorry.

To summarize:

  • You should revert your PR
  • Create a file called Partial.ts
  • Follow the existing structure
  • Stick to the conventional commits
  • Use npm run release -- --no-tags

@millsp
Copy link
Owner

millsp commented Jul 4, 2020

You should write tests for the new utility as well.

@mesqueeb
Copy link
Contributor Author

mesqueeb commented Jul 5, 2020

@pirix-gh I'm so sorry, I didn't realise I had a bunch of unrelated commits on my fork... I only meant to include the last commit... 😅

Thanks so much for all your comments though, I managed to pick up some useful information!!
I'll redo the entire PR with only the commit I meant to include (and in a separate file as per your suggestion) somewhere this week.

@millsp
Copy link
Owner

millsp commented Jul 5, 2020

No problem, it's not always easy to get started on someone else's project. Cheers

@mesqueeb mesqueeb closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millsp millsp millsp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesqueeb @millsp