Pr/partial deep #122
Closed
Pr/partial deep #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pirix-gh As per your request, here's the PR! Let me know if I need to add extra tests or not!! |
millsp
requested changes
Jul 4, 2020
Owner
millsp
left a comment
There was a problem hiding this comment.
Unfortunately, I cannot pull this, sorry.
To summarize:
- You should revert your PR
- Create a file called
Partial.ts - Follow the existing structure
- Stick to the conventional commits
- Use
npm run release -- --no-tags
Owner
|
You should write tests for the new utility as well. |
Contributor
Author
|
@pirix-gh I'm so sorry, I didn't realise I had a bunch of unrelated commits on my fork... I only meant to include the last commit... 😅 Thanks so much for all your comments though, I managed to pick up some useful information!! |
Owner
|
No problem, it's not always easy to get started on someone else's project. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎁 Pull Request
tstfolder)npm testFixes
#109
Why have you made changes?
What changes have you made?
What tests have you updated?
tst/...tst/...Is there any breaking changes?
Anything else worth mentioning?