Fix O.P.Pick to distribute over unions #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎁 Pull Request
tst
folder)npm test
Fixes
Having a non-object in a union as a property breaks
O.P.Pick
for any properties in the union.For example, note how
PartOneAndTwo
incorrectly picks the nested object:This PR fixes
PartOneAndTwo
to evaluate to{a: 'a' | {b: 'ab'}}
.Why have you made changes?
To fix the issues above.
What changes have you made?
O.P.Pick
, making the conditional type distributive. This removes the need to castPicked[K]
to an object and distributesPicked[K]
over all types.What tests have you updated?
O.P.Pick
intst/Object.ts
Is there any breaking changes?
Anything else worth mentioning?
Working with advanced types in TypeScript is really fun 😁