Configurable boss, worker pool sizes. #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Default from SelectorUtil.DEFAULT_IO_THREADS, which is private: | ||
| final int workerCount = Runtime.getRuntime().availableProcessors() * 2; | ||
| public static SSLContext sslContextWithTrustedKeyStore(final String keyStorePath, final String keyStorePassword) |
Contributor
There was a problem hiding this comment.
can you move this back to the end of the class to help github not be weird?
Contributor
Author
There was a problem hiding this comment.
This happened because I was trying to keep the public methods together without a private one in the middle. I can swap them around though if you prefer. let me know.
Contributor
There was a problem hiding this comment.
lazy me says yeah make it easy to review, but sensible me says you're totally right. So SensibleMe wins today
Contributor
|
👍 |
Contributor
Author
|
@drcrallen if you can do a release here, we can get moving on the Druid side |
Contributor
|
@gianm released |
Contributor
Author
|
thanks @xvrl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for apache/druid#3301