Port of the DirectDruidClient response handler. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b9ef5a to
fb91ba4
Compare
Contributor
There was a problem hiding this comment.
thought some logs here will be nice
Contributor
Author
There was a problem hiding this comment.
I had considered that overall, but most of the logs we have in the Druid impl have a lot of stuff solely related to that particular instance. As such, I would expect an implementation to override any method it needs logs for and log ass appropriate before calling the super method.
Since this is an internal handling, I'll add a simple log here in case higher methods do not catch the thrown interrupt.
Contributor
Author
There was a problem hiding this comment.
I added a bunch of debug logging
fb91ba4 to
4bd3f54
Compare
Contributor
|
+1 |
Contributor
|
assuming this is the same code as in Druid +/- some logging seems fine to me |
Contributor
Author
|
@xvrl Yes |
xvrl
added a commit
that referenced
this pull request
Sep 1, 2015
Port of the DirectDruidClient response handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also had to update guava. Minimum 15.0 is needed to capture
ByteSource.empty(). If this is undesirable it can be worked around.