Minimal Python Bindings for ApproxMC #26
Conversation
There was a problem hiding this comment.
First of all, amazing work, thank you so much!! I really-really like it. I think I only found one issue with setup_vars that you seem to declare&define but not use? If that's correct, can we remove it? Or maybe I'm wrong, please let me know!
Thanks a lot, amazing work,
Mate
|
@msoos Woops, I realized that I left a memory leak open and added a fix for that, but I forgot to add a semicolon after it so these won't actually build. It's on line 65, and once it's adding everything works as intended. Sorry about that! |
|
I fixed it, pushed it. Unfortunately, the system is also lacking a simple |
First off, thank you so much for the great tool! I'm using ApproxMC in some experiments for a paper I'm writing so I wrote some minimal Python bindings for it based off of the CryptoMiniSat ones so that I could better integrate it. I tried to follow the same style and naming conventions as well. Unfortunately, I couldn't figure out how to integrate it with your build system, but when built locally it passes a few basic tests I wrote for it.