这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@e-n-f
Copy link
Contributor

@e-n-f e-n-f commented Apr 5, 2019

@ian29
Copy link

ian29 commented Apr 5, 2019

so speedy

@mapsam
Copy link

mapsam commented Apr 5, 2019

Nice @ericfischer! Are commands with quotes " or ' escaped properly?

@e-n-f
Copy link
Contributor Author

e-n-f commented Apr 5, 2019

@mapsam The only explicit escaping is of spaces and backslashes, which should be sufficient in the sqlite3 form. In the JSON form the strings get another level of escaping like anything else in the metadata. But you're right: I should escape all whitespace, not just spaces, because imaginably there could be a newline within the options.

@e-n-f
Copy link
Contributor Author

e-n-f commented Apr 5, 2019

Actually you're totally right @mapsam: I was thinking about JSON quoting, not shell quoting. I'll fix it today.

@e-n-f e-n-f merged commit 18b6473 into master Apr 5, 2019
@e-n-f e-n-f deleted the track-flags branch April 5, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants