Fix glyph width for characters in RTL scripts #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Jan 25, 2021
| { | ||
| "name": "@mapbox/tiny-sdf", | ||
| "version": "1.2.0", | ||
| "version": "1.2.1", |
Member
There was a problem hiding this comment.
Reminder to avoid changing the version in the PR, and do it separately with npm version in the main branch.
mourner
approved these changes
Jan 25, 2021
Member
mourner
left a comment
There was a problem hiding this comment.
👍 given a fast-forward merge to keep the version commit / tag intact in linear history
This was referenced Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
measureTextis not directly measuring glyphs -- it's actually measuring a run of text. When we provide a character from an RTL script, it lays the single-character run of text out right-to-left, and the right of the bounding box ends up being less than the left of the bounding box. TinySDF tries to allocate a negative-size array for the glyph and errors out.I think there may be more work to do to get the
leftmetric correct, but this PR at least avoids the crash and gives something renderable.@mourner