Accepting a lang option and applying it to canvas's ctx.lang #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Unicode, codepoints such as 化 may appear as 化, 化, or 化 depending on the lang tag of the element or page.
While testing the new vector tile layer on OSM, I noticed that switching the UI language between Simplified Chinese, Traditional Chinese, and Japanese updates the map labels in Firefox but not in Chrome. After some testing, I noticed that tiny-sdf has a similar issue in Chrome.
After setting
ctx.lang = "zh-Hant"or relevant language, Chrome will respect the language tag.This PR would add
langas an option in the constructor as in:new TinySDF({ lang: 'zh' })Testing: I proposed a test, but the issue might exist in Node-Canvas too? I'm getting the same data from the two canvases.