feat: use pip dependencies instead of system packages, make lxml mandatory #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
669493b to
8f04470
Compare
8f04470 to
a430c1f
Compare
hwbllmnn
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the system installs of certain packages in the dockerfiles as these were not using the correct python version. Instead the setup.py now includes the needed libraries and they will always be installed via pip. This also removes the need to install these packages if doing a custom install on ubuntu. Additionally shapely, lxml, geos, gdal and pyproj are no longer optional.
This also makes it easier to rely on a certain version of the dependencies.