这是indexloc提供的服务，不要输入任何密码
Skip to content

support POSIX/GNU-style --flags with spf13/pflag #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2016
Merged

support POSIX/GNU-style --flags with spf13/pflag #12

merged 4 commits into from
Jul 7, 2016

Conversation

@briceburg
Copy link
Contributor

@briceburg briceburg commented Apr 15, 2016

Built on top of #10

This consolidates the goflag/pflag library to spf13/plfag ::
3dc0c1c

as opposed to ogier/pflag, spf13/pflag supports "--flag arg" syntax:

@briceburg briceburg changed the title Briceburg/pflag support POSIX/GNU-style --flags with spf13/pflag Jun 22, 2016
@briceburg
Copy link
Contributor Author

briceburg commented Jun 22, 2016 •
edited
Loading

This was not well described. This patch aims to:

  • cleanup code by consolidating the flag parsing (this was done in two parts of the code before)
  • upport POSIX/GNU-style --flags by switching to spf13/pflag package.
mhsendmail --from=user@domain.com test@mailhog.local ...
mhsendmail --from user@domain.com test@mailhog.local ...
mhsendmail --f user@domain.com test@mailhog.local ...

# and the usual
mhsendmail -from "user@domain.com" test@mailhog.local ...

@briceburg briceburg mentioned this pull request Jun 22, 2016
Merged
@ian-kent
Copy link
Member

ian-kent commented Jul 7, 2016

thanks @briceburg, code looks a lot cleaner 👍

@ian-kent ian-kent merged commit 3dc0c1c into mailhog:master Jul 7, 2016
@brammeleman brammeleman mentioned this pull request Nov 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@briceburg @ian-kent @philipcofc