[rom_ext] Add Bound Check to Next Minimum Security Version #27629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81b8790 to
dfa0d44
Compare
Adds an additional check to ensure that the requested security version is not higher than the lowest security version in Slot A or Slot B. Also corrects the requested_min_sec_ver variable to use the proper field name. Signed-off-by: Collin MacDonald <cmacd@google.com>
c0cb589 to
be8ca89
Compare
cfrantz
reviewed
Jul 21, 2025
sw/device/silicon_creator/rom_ext/rom_ext_boot_services_unittest.cc
Outdated
Show resolved
Hide resolved
Updates the existing unit test to use the proper field name, and adds new unit tests to verify that invalid security versions are correctly rejected. Signed-off-by: Collin MacDonald <cmacd@google.com>
Updates the existing e2e test with additional log statements, and update the build file to use the correct manifest versions. Signed-off-by: Collin MacDonald <cmacd@google.com>
be8ca89 to
1819bfc
Compare
cfrantz
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #27628, it is currently possible to set the minimum security version to the higher of the two security versions present in Slot A and Slot B. This should not be possible, as the minimum security version should be restricted to the lowest security version present on the system. This PR adds a check for this, and updates the existing unit tests to check this as well.