[Reggen] Export more properties to SystemRDL #27618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f0be46 to
09514be
Compare
a-will
reviewed
Jul 14, 2025
| valid_components = {Field} | ||
|
|
||
|
|
||
| class Hwre(UDPBoolean): |
There was a problem hiding this comment.
Bleh, it's kind of annoying that we have a separate property here. SystemRDL has swacc for any access and swmod for any change, but those don't map perfectly.
I guess that makes a UDP make sense (for compatibility / reproduction reasons). For a SystemRDL import to reggen (opposite direction), we probably won't care. swacc would generate qe and re, and we don't currently support swmod inside our code generation.
| valid_components = {Reg} | ||
|
|
||
|
|
||
| class Shadowed(UDPBoolean): |
There was a problem hiding this comment.
Seems fine. There's is no standard property for this, only vendor-defined ones. It's too bad the SystemRDL WG is inactive.
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
09514be to
02ba4d1
Compare
02ba4d1 to
4c9d5fe
Compare
4c9d5fe to
9161c1d
Compare
This will be important for systemrdl later. Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
Signed-off-by: Douglas Reis <doreis@lowrisc.org>
9161c1d to
9e430a6
Compare
nbdd0121
reviewed
Jul 21, 2025
| False = 0x69696969; | ||
| }; | ||
|
|
||
| /* `true` if hardware uses `re` signal, which is latched signal of software read pulse.*/ |
There was a problem hiding this comment.
Perhaps explain the difference to swacc here, i.e. swacc = hwre | swmod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR get most of the properties exported to SystemRDL. It also defines some custom properties: