[adc_ctrl, verissimo][UVM69] UVM new() functions #27426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
reviewed
Jun 14, 2025
There was a problem hiding this comment.
I think that Verissimo will actually complain elsewhere about this too: components don't actually need default values for their arguments because we don't create them with the factory. (Or that's what I remember! Maybe check with @antmarzam to make sure I've remembered rightl). So it might be best to drop the default values entirely.
Verissimo complains: The class 'adc_ctrl_env_pkg::adc_ctrl_env_cov' constructor's argument 'name' default value is not an empty string! We create the class object through the create call which creates the object as well as register it to UVM factory. So, leaving the name argument empty inside the constructor will not affect any functionality. Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verissimo complains:
The class 'adc_ctrl_env_pkg::adc_ctrl_env_cov' constructor's argument 'name' default value is not an empty string!
We create the class object through the create call which creates the object as well as register it to UVM factory. So, leaving the name argument empty inside the constructor will not affect any functionality.