[rom] add immutable ROM_EXT section feature #23840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f924421 to
54a9d1f
Compare
cfrantz
reviewed
Jun 28, 2024
sw/device/silicon_creator/rom/e2e/immutable_rom_ext_section/immutable_rom_ext_section_test.c
Outdated
Show resolved
Hide resolved
sw/device/silicon_creator/rom/e2e/immutable_rom_ext_section/immutable_rom_ext_section_test.c
Show resolved
Hide resolved
4 tasks
This adds four fields to support a immutable ROM_EXT section: 1. an enable field, 2. a starting relative offset field, 3. a length field, and 4. a SHA256 hash field. This partially addresses lowRISC#23425. Signed-off-by: Tim Trippel <ttrippel@google.com>
54a9d1f to
11332b4
Compare
This inserts an immutable code partition into the ROM_EXT. The ROM can optionally choose to enforce the immutability property of this region and execute it before handing over execution to the ROM_EXT all based on OTP configurations. This partially addresses lowRISC#23425. Signed-off-by: Tim Trippel <ttrippel@google.com> fix rom_ext build Signed-off-by: Tim Trippel <ttrippel@google.com>
This adds tooling to generate the OTP data needed to embed a non-mutable section in the ROM_EXT to be executed by the ROM. Signed-off-by: Tim Trippel <ttrippel@google.com>
This adds E2E tests to exercise the new ROM_EXT immutable section feature of the ROM. This partially addresses lowRISC#23425. Signed-off-by: Tim Trippel <ttrippel@google.com>
This enhances the immutable ROM_EXT section tests by adding checks for: 1. invalid start offsets, and 2. invalid lengths. Additionally, we now check a magic value set in retention SRAM to ensure the non-mutable section executed during ROM execution. Signed-off-by: Tim Trippel <ttrippel@google.com>
11332b4 to
320e2d1
Compare
cfrantz
approved these changes
Jun 28, 2024
|
adding @vogelpi and @andreaskurth to review the OTP Creator,OwnerSwCfg partitions size changes. |
|
CHANGE AUTHORIZED: hw/ip/otp_ctrl/data/otp_ctrl.hjson |
moidx
approved these changes
Jun 28, 2024
This adds fixed reserved fields to both: 1. CreatorSwCfg (32-byte reserved field) 2. OwnerSwCfg (128-byte reserved field) Signed-off-by: Tim Trippel <ttrippel@google.com>
3cff0b0 to
a535172
Compare
|
CHANGE AUTHORIZED: hw/ip/otp_ctrl/data/otp_ctrl.hjson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #23425 by adding a feature to enable a non-mutable flash section (locked at manufacturing time via OTP fuses) to be executed in the ROM.