[hmac,rtl] HMAC FSM fixes for SAR #23432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements changes to the HMAC FSM to handle SAR and aligns triggering of idle and done. Signed-off-by: Ghada Dessouky <gdessouky@google.com>
andreaskurth
approved these changes
Jun 2, 2024
This was referenced Jun 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements RTL changes to the HMAC FSM to handle context switching (transitions to
StDoneto wait on hash result, and thenStIdlefrom where every context ought to start/continue) and aligns triggering of idle and done. With this change, the SAR smoke test passes on @martin-velay's SAR DV branch (#23116) which tests out SAR across 2 contexts (HMAC + same digest size 256).This hasn't been tested out thoroughly, and I think other issues will come up as DV proceeds. I'm also running a block-level regression at my end. @ballifatih this should close this issue #23352, but I wouldn't be surprised if something else comes up next.