Rename gem to just 'livekit' #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2021 21:58
… absence of other Rubygems built for Livekit
davidzhao
reviewed
Aug 30, 2021
| PATH | ||
| remote: . | ||
| specs: | ||
| livekit-ruby (0.1.0) |
Member
There was a problem hiding this comment.
what do you think about livekit-server-sdk for disambiguation? Since it's possible for it to be one of three things:
- core server
- client sdk
- server sdk
Member
|
renamed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-rubysuffix is redundant, so it's better to follow this simpler convention.Also, remove inaccurate text from the README until we actually add things like a code of conduct or a setup script.