Add SIP API support #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherry
approved these changes
Oct 2, 2024
davidzhao
approved these changes
Oct 2, 2024
Member
davidzhao
left a comment
There was a problem hiding this comment.
lg, and thanks for fixing the video grants
lib/livekit/auth_mixin.rb
Outdated
| ) | ||
| headers = {} | ||
| t = ::LiveKit::AccessToken.new(api_key: @api_key, api_secret: @api_secret) | ||
| t.add_grant(video_grant) |
Member
There was a problem hiding this comment.
should we handle passing in a nil video grant?
Contributor
Author
There was a problem hiding this comment.
It does work right now by constructing a default video grant but I can handle the case explicitly, yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes the
VideoGrantconstructor call withinauth_headercalls explicit for clarity.