AccessToken: stop setting redundant jti claim #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Kotlin server SDK was the only official SDK that included a `jti` claim (set to `identity`) in generated JWTs. Other SDKs and the CLI omit this field, and the LiveKit server does not rely on it. Removing `withJWTId` brings parity across languages and avoids confusion when debugging tokens.
🦋 Changeset detectedLatest commit: 74162f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Summary
Remove
jticlaim from tokens generated by Kotlin Server SDK toalign with LiveKit CLI and other Server SDKs.
🗒️ Motivation
lk token createomitjti.jti; adding it creates inconsistenttokens and duplicates
sub.🔧 Changes
withJWTId(id)call intoJwt().🧪 Testing
jti.🧩 Compatibility
No breaking change. Existing tokens stay valid; new tokens are a subset
of old ones, so server acceptance is unaffected.
📚 References
jti.AccessToken.tsimplementation.