-
Notifications
You must be signed in to change notification settings - Fork 45
feat: apm integration #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated proto file generated classes.
Room Ids are different
Fixcompilererror cdga777
modification trying to fix compiler errors
feat: nullables
* disconnect support * Fix name * To handle better connection and disconnection from room * change to avoid using of Coroutines, using async methods instead * async OnAudioRead * Cleaning logs * Cancel tokens * Cancel token * remove Task.Run, since usually SendRequest is called from other task * getting rid of use YieldInstruction * adding audio filter in main thread * passing CancellationToken instead of CancellationTokenSource * added check for cancellation at beginning * Cleaning handles * fix await * remove cruft * Cancellation token cleanup * Factory async method * basic handling of remaining events * more async * wip * Compile pass * formatting * fix pending check * revert async changes * prep audio filter for threads * loggin * logs to debug publishing track * minor cleanup * added some methods to handle localtrack and SetSubscribed, Clenaing code * Cleaning up * fixes for yield instructions * macro for verbose logs * Audio data and pointer fix Still says samplerate and num of channels are incorrect * remove possibility of null * todo ref buffering * minor cleanup * cruft * todo object pooling * remove redundant Task usages on separated threads --------- Co-authored-by: cdga777 <cdga777@gmail.com> Co-authored-by: nickkhalow <nickhalow@gmail.com>
* remove redundant Task usages on separated threads * FfiRequestsPool * IFFIClient interface * disposable FFIClient * FFIClient initialize simplify * PoolableFFIClient * NativeMethods pass pointer * response pooling * tests for reject manual creation of protocol objects * FfiResponseWrap, remove manual new Request calls * remove IPoolableFFIClient * FFIBridge introduction, remove closures, RAII with FfiResponseWrap and FfiRequestWrap * Clear -> generic ClearMessage
* fix clear message * optimise FfiNewRequest - no FfiHandle * LiveKitInitialize with IntPtr * const format * memory pool * inner message pooling * ArrayMemoryPool with thread safety * remove obsolete * thread safety
# Conflicts: # Runtime/Scripts/Internal/FFIHandle.cs
Now the topic is sent too in the Notification of the data pipe
* Added create track to Room * Refactor RTCAudioSource * updated rooms and audio tracks * added missing metas * Update IRoom.cs * Update Track.cs * Fix to audiosource * Added logs to AudioSource for debugging * removed debug data * Optimized audiosource further * fix for span * Added IAudioFilter interface to allow extending it * Fixes from PR * extracted IRoom reference from AudioTracks * remove audio frame size calculation from audio source
* borrow update generate_proto.sh from main repository * update windows binaries * remove support for linux * update protocol * update macos binaries * update native methods * adopt ffi bridge to new contract
* Fixed publish track logic so it gets properly added to tracks and events properly find it * extracted interface for rtcAudioSource * changed AudioRead to use spans and renamed AudioSource to RtcAudiosSource to avoid confusions * Update OptimizedRtcAudioSource.cs * Added AudioSourceOptions to enable advanced WebRTC features * Improvements to OptimizedRTCAudioSource * Improved ConnectionUpdate return value with disconnection reason * Revert "Improved ConnectionUpdate return value with disconnection reason" This reverts commit 449239d. * added cleanup of speakers and participants on Disconnect * Cleanup of participants on disconnection from room * Improvements to audio source and audio stream + fixes for room and participants hub * Update ParticipantsHub.cs * Update OptimizedRtcAudioSource.cs * renamed file to better reflect its use * Update OptimizedMonoRtcAudioSource.cs
… Out of Range exception
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.