这是indexloc提供的服务,不要输入任何密码
Skip to content

Handle e2ee worker messages sequentially #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Sep 30, 2024

with sped up publication we've seen instances where the key on the worker had not been set yet while the cryptor was already trying to encode first frames.
This PR tries to mitigate these instances threefold

  • process incoming worker messages sequentially in an async queue
  • post keys before posting enable messages
  • instead of throwing an error within the encode function, emit the cryptorError event and return early without enqueuing a frame

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 84eab25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 30, 2024

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 83.25 KB (0%)
dist/livekit-client.umd.js 89.14 KB (0%)

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lukasIO lukasIO merged commit 18714f7 into main Sep 30, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/sequential-e2ee-messages branch September 30, 2024 20:02
@github-actions github-actions bot mentioned this pull request Sep 30, 2024
svajunas-budrys pushed a commit to svajunas-budrys/client-sdk-js that referenced this pull request Jun 17, 2025
* Handle e2ee worker messages sequentially

* Create cyan-mayflies-design.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants