fix the warnings and remove the ignorance from flutter analyze #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @hiroshihorie and @cloudwebrtc , please review this PR. |
hiroshihorie
approved these changes
Oct 30, 2025
Member
hiroshihorie
left a comment
There was a problem hiding this comment.
LGTM for this pass, we can incrementally do more fixes.
lib/src/support/native.dart
Outdated
Comment on lines
167
to
169
| channel.invokeMethod('broadcastRequestActivation', <String, dynamic>{}); | ||
| unawaited(channel.invokeMethod('broadcastRequestActivation', <String, dynamic>{})); |
Member
There was a problem hiding this comment.
I think throwing errors won't propagate anymore, we might need to make broadcastRequestActivation() async.
Comment on lines
-78
to
+79
| updateFromInfo(info); | ||
| // updateFromInfo() is sync, no need to wait here. | ||
| unawaited(updateFromInfo(info)); |
Member
There was a problem hiding this comment.
It's probably ok like this, but I might re-factor this part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed some of the error ignorances from analysis_options.yaml and fixed the warnings.