-
Notifications
You must be signed in to change notification settings - Fork 201
fix: Properly handle broadcast capture state #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mirrors API of the same class from the native Swift SDK.
Unneeded functionality has been omitted.
This is necesary to allow using the Combine framework. Since the minimum deployment target is iOS 13 according to the Podspec, this should not cause any issues.
Same solution as implemented in PR livekit#551 for the native Swift SDK.
Sets the `deviceId` constraint to `broadcast-manual`, ensuring the broadcast picker isn't presented a second time when publishing a screen share track.
Removes boilerplate for iOS broadcast state management now handled internally by the library.
cloudwebrtc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg!
|
The corresponding flutter-webrtc has been released |
|
hey @ladvoc, There is a small issue preventing CI from passing, can you try running |
|
I noticed that there is no place where BroadcastManager.requestStop is called. This causes the iOS system to remain in the recording state when screen sharing is disabled, and the next time screen sharing is enabled, an exception will occur. |
Summary of changes
BroadcastManagerclass gives developers control over the broadcast state and track publication for advanced use cases.Fixes
Minor breaking changes
setScreenShareEnabledorsetSourceEnabledon LocalParticipant currently returns a LocalTrackPublication representing the newly published screen share track. After this change, when using the broadcast capturer on iOS, this method will return null, as the track will be published asynchronously pending user approval. Developers should treat enabling screen share as a request that might not be fulfilled and should not interpret null return values from these methods as errors.setSourceEnabledwhen enabling screen sharing.Additional context
Outstanding items