move the accessToken to header #891
Conversation
|
Thanks @hiroshihorie, do we have any setups for the flutter format ? like using a script or some setups on Android Studio ? |
|
flutter analyze gives me the same errors on main, I put in some lines of code in analysis_options.yaml to suppress the warnings instead. |
|
Hi @hiroshihorie @cloudwebrtc , could you please help review this PR? |
|
@xianshijing-lk You just need to run |
| use_super_parameters: ignore | ||
| avoid_print: ignore | ||
| use_build_context_synchronously: ignore | ||
| discarded_futures: ignore |
There was a problem hiding this comment.
discarded_futures are something we should fix soon for safer code, but it's fine to suppress it temporary if we don't forget about it.
There was a problem hiding this comment.
There are quite a few instance of discarded_futures warnings, let me take a follow-up to address it and re-enable the warnings.
Added a TODO here.
9e7c2f4 to
ec35029
Compare
|
I rebased then got 4 more analyze warnings, I just fixed them as I think some of them worth fixing now I think the next step might be address all those issues and re-enable the analyze warnings. |
|
@xianshijing-lk LGTM, yes I'll fix other analyze errors in another branch. The test not passing is due to recent changes. |
Changes made to v2.5.3: - Removed DataPacketCryptor from E2EEManager (no longer instantiated) - Removed dcEncryptionEnabled parameter from E2EEManager constructor - Removed isDataChannelEncryptionEnabled, encryptData(), handleEncryptedData() methods - Removed data packet encryption logic from Engine.sendDataPacket() - Removed asEncryptablePacket() and asDataPacket() helper methods from Engine - Simplified encrypted packet handling to log warning instead of decrypt - Downgraded WebRTC-SDK from 137.7151.04 to 137.7151.03 in iOS podspec All other v2.5.3 features preserved: ✓ ParticipantCreationResult and event ordering fixes (PR livekit#902) ✓ H265 E2EE support (PR livekit#864) ✓ Async participant info updates (PR livekit#897) ✓ Access token in header (PR livekit#891) ✓ Connection timeout fixes (PR livekit#893)
Move the access_token to header in the format of 'Authorization': 'Bearer $token'