这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Oct 14, 2025

Separate format / analyze / test jobs

@hiroshihorie hiroshihorie changed the title Update ci chore: update ci Oct 14, 2025
…in permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@hiroshihorie hiroshihorie requested a review from Copilot October 14, 2025 09:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restructures the CI workflow by separating the monolithic format/analyze/test job into individual jobs and updating GitHub Actions versions and configuration.

  • Split the combined dart-format-and-analyze-check job into separate format, import sorter, version consistency, analyze, and test jobs
  • Updated GitHub Actions from v2 to v4 and standardized naming conventions
  • Added workflow permissions and improved step naming consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- uses: actions/checkout@v2
- name: Clone repository
uses: actions/checkout@v4
- uses: actions/setup-java@v1
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions/setup-java@v1 action is deprecated. Consider updating to actions/setup-java@v4 for better security and performance.

Suggested change
- uses: actions/setup-java@v1
- uses: actions/setup-java@v4

Copilot uses AI. Check for mistakes.
- uses: actions/checkout@v2
- name: Clone repository
uses: actions/checkout@v4
- uses: subosito/flutter-action@v1
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent flutter-action version. This job uses @v1 while other jobs use @v2. Consider updating to @v2 for consistency.

Copilot uses AI. Check for mistakes.
- uses: actions/checkout@v2
- name: Clone repository
uses: actions/checkout@v4
- uses: subosito/flutter-action@v1
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent flutter-action version. This job uses @v1 while other jobs use @v2. Consider updating to @v2 for consistency.

Copilot uses AI. Check for mistakes.
- uses: actions/checkout@v2
- name: Clone repository
uses: actions/checkout@v4
- uses: actions/setup-java@v1
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions/setup-java@v1 action is deprecated in multiple jobs. Consider updating to actions/setup-java@v4 for better security and performance.

Copilot uses AI. Check for mistakes.
- uses: actions/checkout@v2
- name: Clone repository
uses: actions/checkout@v4
- uses: actions/setup-java@v1
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions/setup-java@v1 action is deprecated in multiple jobs. Consider updating to actions/setup-java@v4 for better security and performance.

Copilot uses AI. Check for mistakes.
Comment on lines +31 to +32
- name: Clone repository
uses: actions/checkout@v4
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The repeated 'Clone repository' step pattern across multiple jobs creates maintenance overhead. Consider using a reusable workflow or job template to reduce duplication.

Copilot uses AI. Check for mistakes.
Comment on lines +46 to +47
- name: Clone repository
uses: actions/checkout@v4
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The repeated 'Clone repository' step pattern across multiple jobs creates maintenance overhead. Consider using a reusable workflow or job template to reduce duplication.

Copilot uses AI. Check for mistakes.
Comment on lines +61 to +62
- name: Clone repository
uses: actions/checkout@v4
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The repeated 'Clone repository' step pattern across multiple jobs creates maintenance overhead. Consider using a reusable workflow or job template to reduce duplication.

Copilot uses AI. Check for mistakes.
Comment on lines +76 to +77
- name: Clone repository
uses: actions/checkout@v4
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The repeated 'Clone repository' step pattern across multiple jobs creates maintenance overhead. Consider using a reusable workflow or job template to reduce duplication.

Copilot uses AI. Check for mistakes.
Comment on lines +91 to +92
- name: Clone repository
uses: actions/checkout@v4
Copy link

Copilot AI Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The repeated 'Clone repository' step pattern across multiple jobs creates maintenance overhead. Consider using a reusable workflow or job template to reduce duplication.

Copilot uses AI. Check for mistakes.
@hiroshihorie hiroshihorie merged commit 524d559 into main Oct 14, 2025
20 of 27 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/update-build-ci branch October 14, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants