fix(web, firefox): backup old values before overwriting them #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@cloudwebrtc looks like this needs a force merge as well. Thank you! |
Contributor
|
hey @td-famedly, This line forces the non-null check to be ignored, which may cause a crash. I think it may need to be modified. |
Contributor
Author
|
@cloudwebrtc fixed by falling back to the current encoding if there is no backup |
Contributor
Author
|
I had to run |
Contributor
|
lg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if the comment about disabling layers in Firefox is still accurate.
In any case, this PR fixes an issue where quality would not get back up anymore once higher quality levels were disabled because the bitrate/framerate/scale values were overwritten in a shallow copy of the encoding
This PR introduces a backup map to properly copy and restore the modified values