fix: update camera deviceId when track is null
#814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no `LocalVideoTrack` while we are in the call, `setVideoInputDevice` will skip the device selection as a whole since `track` is `null`. This will result in a wrong device being used to create a track.
|
|
td-famedly
suggested changes
Jun 26, 2025
cloudwebrtc
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no
LocalVideoTrackwhile we are in the call,setVideoInputDevicewill skip the device selection as a whole sincetrackisnull.This will result in a wrong device being used to create a track.
flowchart TD A["Join room with video OFF (X)"] --> B[No video track published] B --> C["Select new camera device (Y)"] C --> D{Is video track available?} D -- No --> E[track is null, switchCamera skipped] E --> F[roomOptions not updated] F --> G[Turn on video] G --> H["New track uses old device (X)"] H --> I[Camera shows wrong input]