Add attribute typings for agent and transcription #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new file `attribute-typings.dart` defining Dart classes and enums for agent and transcription attributes, including JSON serialization helpers. Also exports this new typings file from the main library entry point.
There was a problem hiding this comment.
Pull Request Overview
Adds a new Dart file defining models and enums for agent and transcription attributes with JSON (de)serialization, and exports it from the main library.
- Introduce
attribute-typings.dartcontainingAgentAttributes,TranscriptionAttributes, enums, and anEnumValueshelper. - Export the new typings file and merge the conditional export for
processor_native.dartinto a single line.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/src/types/attribute-typings.dart | New models/enums with JSON serialization for agent/transcription attributes |
| lib/livekit_client.dart | Merged conditional export line and added export for attribute typings file |
Comments suppressed due to low confidence (3)
lib/livekit_client.dart:62
- [nitpick] Dart style guide recommends using lowercase_with_underscores for file names; consider renaming attribute-typings.dart to attribute_typings.dart and updating its references.
export 'src/types/attribute-typings.dart';
lib/src/types/attribute-typings.dart:8
- [nitpick] Consider adding doc comments to explain the purpose and usage of this JSON deserialization helper to improve clarity for public API consumers.
AgentAttributes agentAttributesFromJson(String str) => AgentAttributes.fromJson(json.decode(str));
lib/src/types/attribute-typings.dart:18
- [nitpick] These list fields are nullable but default to empty lists in fromJson; consider making them non-nullable (List) or returning null consistently to align the API design.
List<AgentInput>? lkAgentInputs;
| lkAgentOutputs: json['lk.agent.outputs'] == null | ||
| ? [] | ||
| : List<AgentOutput>.from(json['lk.agent.outputs']!.map((x) => agentOutputValues.map[x]!)), | ||
| lkAgentState: agentStateValues.map[json['lk.agent.state']]!, |
There was a problem hiding this comment.
This force unwrap will throw if 'lk.agent.state' is missing or null; consider handling a null case (e.g., using a null-aware lookup) to avoid runtime exceptions.
Suggested change
| lkAgentState: agentStateValues.map[json['lk.agent.state']]!, | |
| lkAgentState: json['lk.agent.state'] != null ? agentStateValues.map[json['lk.agent.state']] : null, |
cloudwebrtc
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new file
attribute-typings.dartdefining Dart classes and enums for agent and transcription attributes, including JSON serialization helpers. Also exports this new typings file from the main library entry point.