Change AudioSession configuration logic #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidliu
approved these changes
Apr 7, 2022
Contributor
davidliu
left a comment
There was a problem hiding this comment.
LGTM, just some naming changes suggested.
lib/src/track/local/local.dart
Outdated
|
|
||
| @internal | ||
| @mustCallSuper | ||
| Future<bool> publish() async { |
Contributor
There was a problem hiding this comment.
Should rename to onPublish() just to be clear that this doesn't actually do the track publishing itself.
lib/src/track/local/local.dart
Outdated
|
|
||
| @internal | ||
| @mustCallSuper | ||
| Future<bool> unpublish() async { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, mute/unmute will not switch audio category just like Swift SDK.
Un-publishing local audio track will stop the mic indicator.