这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@cloudwebrtc
Copy link
Contributor

No description provided.

@cloudwebrtc cloudwebrtc added the v2 label Jan 4, 2024
Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

one question: is it necessary to change it to lower case enums? I think we still use some upper case enums in the code base? Question is if it's worth making users change all of these enums.

@cloudwebrtc
Copy link
Contributor Author

nice work!

one question: is it necessary to change it to lower case enums? I think we still use some upper case enums in the code base? Question is if it's worth making users change all of these enums.

Makes sense, but changing to uppercase will cause a dart-style prompt requiring lowerCamelCase, unless we change analysis_options.yaml to disable lowerCamelCase mandatory requirements.

image

@davidzhao
Copy link
Member

Makes sense, but changing to uppercase will cause a dart-style prompt requiring lowerCamelCase, unless we change analysis_options.yaml to disable lowerCamelCase mandatory requirements.

Got it. I think that would be preferable instead of forcing users to update all the enum references. wdyt?

@cloudwebrtc cloudwebrtc merged commit 63be320 into main Jan 8, 2024
@cloudwebrtc cloudwebrtc deleted the v2/remove-video-quality-off branch January 8, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants