这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix camera lookup to check for physicalId #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2025
Merged

Fix camera lookup to check for physicalId #792

merged 3 commits into from
Nov 6, 2025
+15 −2

Conversation

@KasemJaffer
Copy link
Contributor

@KasemJaffer KasemJaffer commented Nov 4, 2025

This fixes the following crashes that occur on some devices. I guess it was working before because cameraId and physicalId happen to match in most devices.

  Fatal Exception: java.util.NoSuchElementException: Collection contains no element matching the predicate.
       at livekit.org.webrtc.CameraXSession.obtainCameraConfiguration(CameraXSession.kt:382)
       at livekit.org.webrtc.CameraXSession.openCamera$lambda$12(CameraXSession.kt:157)
       at android.os.Handler.handleCallback(Handler.java:995)
       at android.os.Handler.dispatchMessage(Handler.java:103)
       at android.os.Looper.loopOnce(Looper.java:273)
       at android.os.Looper.loop(Looper.java:363)
       at android.os.HandlerThread.run(HandlerThread.java:85)

@KasemJaffer
Fix camera lookup to check physicalId
a8e2afc 
Check `physicalId` in addition to `deviceId` when looking up the camera configuration. This resolves issues on devices where the logical and physical camera IDs may differ.
@KasemJaffer
Add changeset
1c37dc6
@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: bd2b6a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
client-sdk-android Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davidliu davidliu merged commit 650c35a into livekit:main Nov 6, 2025
2 checks passed
@davidliu davidliu mentioned this pull request Nov 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidliu davidliu davidliu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KasemJaffer @davidliu