feat: TokenSource implementation #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e1c9f81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pblazej
reviewed
Oct 8, 2025
livekit-android-sdk/src/main/java/io/livekit/android/token/CachingTokenSource.kt
Show resolved
Hide resolved
pblazej
reviewed
Oct 8, 2025
livekit-android-sdk/src/main/java/io/livekit/android/token/TokenSource.kt
Outdated
Show resolved
Hide resolved
pblazej
reviewed
Oct 8, 2025
pblazej
left a comment
There was a problem hiding this comment.
I really like the similarities between Swift and Kotlin (as both diverged from web, unfortunately), let's make sure we align them perfectly.
1egoman
reviewed
Oct 9, 2025
livekit-android-sdk/src/main/java/io/livekit/android/token/TokenSource.kt
Outdated
Show resolved
Hide resolved
livekit-android-sdk/src/main/java/io/livekit/android/token/TokenSource.kt
Show resolved
Hide resolved
livekit-android-sdk/src/main/java/io/livekit/android/token/JWTPayload.kt
Outdated
Show resolved
Hide resolved
livekit-android-sdk/src/main/java/io/livekit/android/token/EndpointTokenSource.kt
Show resolved
Hide resolved
e610079 to
07e88e1
Compare
Merged
pblazej
added a commit
to livekit/client-sdk-swift
that referenced
this pull request
Oct 14, 2025
Incarnation of: - livekit/client-sdk-js#1645 🌏 - livekit/client-sdk-android#769 🤖 Key differences: - Mostly leverages Swift-native approach (protocols + default impl) - Caching is opt-in wrapper (which could be extended to Keychain tho)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.