Optimizations for proguard #803
Draft
+16
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 276dfd7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adrian-niculescu
suggested changes
Nov 17, 2025
| -keep class livekit.org.webrtc.** { *; } | ||
|
|
||
| # JNI Zero initialization (required for WebRTC native method registration) | ||
| -keep class livekit.org.jni_zero.JniInit { |
Contributor
There was a problem hiding this comment.
@davidliu, I tested this change on a release build and got:
2025-11-17 14:59:48.363 18718-18968 System.err W java.lang.ClassNotFoundException: livekit.org.jni_zero.JniInit
2025-11-17 14:59:48.363 18718-18968 System.err W at java.lang.Runtime.nativeLoad(Native Method)
2025-11-17 14:59:48.363 18718-18968 System.err W at java.lang.Runtime.loadLibrary0(Runtime.java:1088)
2025-11-17 14:59:48.363 18718-18968 System.err W at java.lang.Runtime.loadLibrary0(Runtime.java:1012)
2025-11-17 14:59:48.363 18718-18968 System.err W at java.lang.System.loadLibrary(System.java:1765)
2025-11-17 14:59:48.363 18718-18968 System.err W at livekit.org.webrtc.PeerConnectionFactory.k(r8-map-id-90f24bdfa111a01f7121043ad3cf72729799e3410d60489d64de3d171e47221a:41)
2025-11-17 14:59:48.363 18718-18968 System.err W at e8.e.call(r8-map-id-90f24bdfa111a01f7121043ad3cf72729799e3410d60489d64de3d171e47221a:88)
2025-11-17 14:59:48.363 18718-18968 System.err W at java.util.concurrent.FutureTask.run(FutureTask.java:317)
2025-11-17 14:59:48.363 18718-18968 System.err W at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1156)
2025-11-17 14:59:48.363 18718-18968 System.err W at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:651)
2025-11-17 14:59:48.363 18718-18968 System.err W at java.lang.Thread.run(Thread.java:1119)
2025-11-17 14:59:48.363 18718-18968 jni_zero W jni_zero.cc:38 Failed to find class livekit/org/jni_zero/JniInit
so that keep rule still seems needed.
I now this is only a draft, just letting you know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.