fix type checks for plugins #2423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
theomonnom
approved these changes
May 29, 2025
| @@ -198,7 +202,7 @@ def __init__( | |||
| entra_token: str | None = None, | |||
| api_key: str | None = None, | |||
| api_version: str | None = None, | |||
| base_url: str | None = None, | |||
| base_url: NotGivenOr[str] = NOT_GIVEN, | |||
There was a problem hiding this comment.
nit, I generally prefer to use str | None over NotGivenOr when we don't need to.
(we tend to over-use NotGiven in our codebase, but it's OK)
jayesh-mivi
pushed a commit
to mivi-dev-org/custom-livekit-agents
that referenced
this pull request
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async def connection(self, *, timeout: float) -> AsyncGenerator[T, None]