Add support for memory-mapped devices #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The I/O port mode is only available on x86 or x86-64: rename the constructor and add conditionally-compile it accordingly.
Contributor
Author
|
I’m fairly sure the new tests passed when I worked on this several months ago, but now I get the same failure as on CI and I don’t know what to try next :( |
|
Could you create this issue on QEMU bug tracker? |
Contributor
Author
|
I believe this is the same as https://gitlab.com/qemu-project/qemu/-/issues/1343 |
Owner
|
Merged with #2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for non-Intel architectures without "I/O ports" where a fw-cfg device is mapped into main memory instead. The base address needs to be passed as a parameter to a new constructor.