这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@SimonSapin
Copy link
Contributor

@SimonSapin SimonSapin commented Jun 26, 2022

1.59.0 is the version that stabilized the asm! macro for inline assembly.

The README previously said that Nightly is required, but that turned to be the case only for cross-compiling to i686-unknown-none.

@SimonSapin SimonSapin force-pushed the stable branch 2 times, most recently from cf2832a to 83d704b Compare June 26, 2022 08:48
@SimonSapin SimonSapin changed the title Document and test Rust 1.40.0 as minimum supported version Document and test Rust 1.59.0 as minimum supported version Jun 26, 2022
Otherwise we might hit 404 errors when trying to download outdated package versions.
Since it is required for testing with Cargo’s build-std
@SimonSapin SimonSapin force-pushed the stable branch 2 times, most recently from d421835 to 6a32fa3 Compare June 26, 2022 15:11
1.59.0 is the version that stabilized the asm! macro for inline assembly.

The README previously said that Nightly is required,
but that turned to be the case only for cross-compiling to i686-unknown-none.
@lion328
Copy link
Owner

lion328 commented Jun 27, 2022

Thanks for the PR!

Yeah this LGTM, but I noticed that Rust 1.59.0 CI doesn't seem to do anything. Did you planned to add more tests to that later?

@SimonSapin
Copy link
Contributor Author

Yes. At some point I changed it to build on x86_64-unknown-linux-gnu as a placeholder for "something that has pre-compiled libcore in rustup" but then decided it wasn’t particularly useful. #2 does add CI for RISC-V which works on stable (if alloc is disabled).

By the way, how do you feel about making alloc a non-default feature? I tend to prefer avoiding default features, though the effects are more pronounced for crates that typically have multiple dependents in the same project: all of them need to opt out for a default feature not to be implicitly requested, and there’s no way to opt out of a single feature.

@lion328
Copy link
Owner

lion328 commented Jun 29, 2022

By the way, how do you feel about making alloc a non-default feature? I tend to prefer avoiding default features, though the effects are more pronounced for crates that typically have multiple dependents in the same project: all of them need to opt out for a default feature not to be implicitly requested, and there’s no way to opt out of a single feature.

For my use cases I normally use alloc, that's why it's a default feature. But yes I agree with you. If you want to change it then go ahead. I'm going to merge this one for now.

@lion328 lion328 merged commit a561fde into lion328:master Jun 29, 2022
@SimonSapin SimonSapin deleted the stable branch June 29, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants