Bug: center multiline text in custom ChoiceChip #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axl-Lvy
commented
Jun 8, 2025
Comment on lines
142
to
136
| class _ChoiceChip extends StatelessWidget { | ||
| const _ChoiceChip({ | ||
| required this.title, | ||
| this.subtitle, | ||
| this.speed, | ||
| required this.onTap, | ||
| super.key, | ||
| }); | ||
|
|
||
| final Widget title; | ||
| final Widget? subtitle; | ||
| final Speed? speed; | ||
| // Base class for choice chips. | ||
| abstract class _ChoiceChip extends StatelessWidget { |
There was a problem hiding this comment.
IMO it's clearer this way, but I can revert this refactoring if you want.
The point of this change is to separate the logic dedicated to each component.
| final String title; | ||
|
|
||
| @override | ||
| List<Widget> get children => [Text(title, textAlign: TextAlign.center)]; |
There was a problem hiding this comment.
All the fix is in the TextAlign.center
veloce
reviewed
Jun 9, 2025
|
yep, it's explained why here: #1848 (comment) |
|
Done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1750
Hi! This is my first contribution to this awesome app :)
I don't know if it is necessary to test the disposition of the quick game matrix.