Fix: Make opponent's clock red when a player flags (issue #1561) #1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloce
reviewed
Apr 2, 2025
lib/src/widgets/clock.dart
Outdated
| @@ -73,6 +73,8 @@ class Clock extends StatelessWidget { | |||
| ? isEmergency | |||
| ? effectiveClockStyle.emergencyBackgroundColor | |||
| : effectiveClockStyle.activeBackgroundColor | |||
| : isEmergency | |||
There was a problem hiding this comment.
It adds the red background when flagged, but it also adds the red background when the game is still running and it is not the active side... not sure we want that.
|
veloce
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1561