这是indexloc提供的服务,不要输入任何密码
Skip to content

Prevent overflow of material advantage display #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

jas14
Copy link
Collaborator

@jas14 jas14 commented Sep 6, 2022

Should fix #2178.

Before

When a player's material advantage takes more than the available screen space to display, it currently wraps, which displaces the board:

Screen Shot 2022-09-06 at 7 16 19 PM

After

Material advantage row is height-restricted to exactly one piece. Advantage number is never hidden, but individual piece representations are hidden when necessary.

Screen Shot 2022-09-06 at 7 13 12 PM

Does not affect screens of sufficient width.

Screen Shot 2022-09-06 at 7 13 06 PM

@veloce veloce merged commit feac49c into lichess-org:master Sep 7, 2022
@jas14 jas14 deleted the prevent-material-overflow branch September 7, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Board displaced due to material advantage overflow
2 participants