Fall back on random puzzle when not found #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1728. Until we implement Puzzles V2, this will provide a better experience for users who click on a
/training/<theme>link.If any of the theme names happen to base62-decode to a real puzzle ID, the app will appear to load a totally unrelated puzzle. I'm assuming that will not happen / it seems more effort than it's worth for now to hard-code all the possible theme names to match against the provided puzzle ID.
Note: no toasts in the below screen recordings because they're on web, for which LiToast isn't implemented.
Before
Screen.Recording.2021-09-23.at.11.02.33.AM.mov
After
Screen.Recording.2021-09-23.at.11.04.14.AM.mov